Repository navigation
Conversation
tang-vu
force-pushed
the
feat/resources-scoped-service-filter-20260919
branch
from
September 19, 2026 03:39
336ac7d to
f20c387
Compare
Integrate reviewed fleet installer and Pixel runtime fixes, including distinct browser/installer model-control IPC and fail-closed cleanup of verified provider service files. Exact PR head passed 43 GitHub checks (3 skipped). This merges into public-beta for renewed five-machine installed qualification; it is not a five-machine acceptance receipt.
tang-vu
force-pushed
the
feat/resources-scoped-service-filter-20260919
branch
from
September 19, 2026 04:51
cf593e1 to
553114d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/services/resourcesaccepts repeatedserviceids (≤50, charset-validated) andinclude_disk=falseto skip the disk sampler.cpu_percent,memory_used_mb,disk_data_gb) are recomputed over the selected services; unknown ids → 404, malformed ids → 400.scopeblock (services,disk_included) so consumers can distinguish a filtered snapshot from a fleet-wide one.docs/RESOURCE_SNAPSHOTS.md; cover withtests/test_resource_scopes.py(7 cases).Why this matters
Dashboard panels that need only one or two services previously paid the full fleet sampling cost and had no way to request a disk-free payload — the disk walk is the most expensive part of the endpoint. Scoping is additive and the unfiltered response shape is unchanged.
Overlap check
resources,service_resources,snapshot,resources.py— feat(resources): expose authenticated kernel pressure snapshots #4896 adds kernel pressure snapshots (resource_pressure.py+ a different handler region in the same file); fix(dashboard-api): coerce null metric values in resource totals calculation #5469/fix(service-registry): coerce scalar and null dependencies and aliases to lists #5470 touch metric-total null guards and service-registry coercion, not this endpoint.Test plan
python -m pytest tests/test_resource_scopes.py— 7 passed locally.