Repository navigation
fix(pixel-chat): reject empty attempt string in chat result store key - #5732
Closed
Vishaaallll wants to merge 1 commit into
Closed
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
Signed-off-by: Vishaaallll <Vishaaallll@users.noreply.github.com>
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/extensions/services/dashboard-api/pixel_chat_results.py,ChatResultStore.reserve(self, key, fingerprint)unpackskeydirectly into SQL queries without verifying that all 3 components (owner,chat,attempt) are non-empty strings. If empty strings or incorrect tuple lengths are passed, malformed records are inserted into the SQLite database, causing primary key collisions or orphaned SSE receipt attempts.This surgical fix validates that
keyis a 3-element tuple or list of non-empty strings, raisingValueError("Invalid result store key")otherwise.Validation
store.reserve(("", "chat1", "att1"), "fp")inserted rows with empty strings on baseline.ValueError.pixel-chat suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5695 touched chat cancellation; zero overlap with store key validation in
pixel_chat_results.py.Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Strictly defends store key integrity before database transactions. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. CI and unit checks pass.