fix(pixel-settings): allow explicit thinking off when provider omits off from levels - #5723
Open
Vishaaallll wants to merge 1 commit into
Open
Vishaaallll wants to merge 1 commit into
Vishaaallll wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/bin/pixel_settings/contract.py,preview_preferences(preferences, capabilities)rejectedthinkingvalues that were not explicitly included incapabilities["supportedThinkingLevels"]. When an inference provider only lists active levels (such as["low", "medium", "high"]) or does not support extended thinking at all ([]), an owner's explicit request to turn thinking off (thinking: "off") was rejected withSettingsError("thinking-level-not-supported").This surgical fix permits
thinking: "off"unconditionally, as disabling reasoning is the standard baseline state and does not require extended thinking capabilities.Validation
preview_preferences({"thinking": "off"}, caps)raisedSettingsErrorwhensupportedThinkingLevelsdid not contain"off".thinking: "off"while continuing to reject unsupported active levels.pixel-settings suite: 2 passed. New-test syntax and diff checks pass; new regression wired into Linux CI.Overlap check
Inspected open/closed PRs. PR #5616 touched capabilities boundaries; PR #5696 touched provider limits. Neither addresses explicit
thinking: "off"permission inpreview_preferences.Risk / AI disclosure
AI-assisted investigation, patch, and regression tests. Strictly relaxes rejection for the disabled thinking state. Independent review remains a gate.
Follow-up integration evidence
Composed locally with public-beta at
4fa6ad170without conflicts. Regression tests pass.