Repository navigation
fix(preflight): guard load_env_file presence in ods-preflight.sh - #5601
Closed
vaibhavsrv wants to merge 1 commit into
Closed
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/ods-preflight.sh,load_env_filewas invoked directly after conditionally sourcingsafe-env.sh. Iflib/safe-env.shwas absent,load_env_fileremained undefined and crashed preflight withcommand not foundunderset -euo pipefail.Guard both helper sourcing and
.envloading in an explicit block, ensuring safe fallback when environment helpers are not present.Validation
safe-env.shis missing aborted on unboundload_env_file.test_preflight_safe_env_guard.pyexecutes preflight and verifies absence of command-not-found failures.Overlap check
Searched live open/closed PRs by
ods-preflight.sh. #5126 handles readonly variables; this hardens preflight helper availability.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens preflight execution. Independent review remains a gate.
Follow-up integration evidence
Composed with #5126 at 5126 without conflicts. Preflight verification workflows remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.