Use capture_output=True instead of stdout=PIPE, stderr=PIPE (UP022) - #5576
Open
AniketBajaj2024 wants to merge 1 commit into
Open
AniketBajaj2024 wants to merge 1 commit into
AniketBajaj2024 wants to merge 1 commit into
Conversation
subprocess.run accepts capture_output as shorthand for passing both PIPE arguments. Ruff marks this fix 'unsafe' because the rewrite is invalid for subprocess.Popen, which has no capture_output parameter — verified all four call sites are subprocess.run, with zero Popen usage in the diff. Confirmed equivalence at runtime: both spellings produce identical stdout and stderr. All four touched files byte-compile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
subprocess.run accepts capture_output as shorthand for passing both PIPE arguments. Ruff marks this fix 'unsafe' because the rewrite is invalid for subprocess.Popen, which has no capture_output parameter — verified all four call sites are subprocess.run, with zero Popen usage in the diff.
Confirmed equivalence at runtime: both spellings produce identical stdout and stderr. All four touched files byte-compile.