fix(validate-models): support exported variables in env_value in validate-models.py - #5563
Open
vaibhavsrv wants to merge 1 commit into
Open
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/validate-models.py,env_value()checked lines withline.startswith(f"{key}="). In installations where.enventries are prepended withexport, model and backend settings were missed, causing validation to silently fall back to default configuration.Strip leading
exportprefixes prior to key matching, ensuring consistency with shell environment definitions.Validation
env_value()withexport ODS_MODE=cloudfailed to read the key and returnedlocal.test_validate_models_export_prefix.pyvalidates that export-prefixed configuration keys are recognized.Overlap check
Searched live open/closed PRs by
validate-models.py. #5402 handles offline GGUF checks; this aligns environment variable reading.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens model environment validation. Independent review remains a gate.
Follow-up integration evidence
Composed with #5402 at 3c186f3 without conflicts. Model validation routines remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.