fix(select-model): allow float values for ram-gb and vram-mb in select-model.py - #5561
Open
vaibhavsrv wants to merge 1 commit into
Open
vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
vaibhavsrv
force-pushed
the
fix/select-model-float-ram-arg
branch
from
September 17, 2026 04:47
2b8854e to
57f6f45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/select-model.py,--ram-gband--vram-mbarguments were registered withtype=int. When hardware detection tools passed fractional memory readings (such as15.8on 16GB systems with reserved regions),argparsethrew an unhandled parse error and exited with status 2.Change argument types to
type=float, matching the internal float arithmetic used byusable_memory_gb()andmatching_runtime_profile().Validation
select-model.py ... --ram-gb 15.8crashed witherror: argument --ram-gb: invalid int value: '15.8'.test_select_model_float_ram_args.pyruns with float memory arguments and verifies successful model recommendation.Overlap check
Searched live open/closed PRs by
select-model.py. #5372 touches model identity during streams; this hardens CLI memory argument conversion.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens CLI argument type conversion. Independent review remains a gate.
Follow-up integration evidence
Composed with #5372 at 3c186f3 without conflicts. Model selection contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.