Repository navigation
fix(cold-storage): ensure cold storage directory exists before archiving idle models in llm-cold-storage.sh - #5557
Closed
vaibhavsrv wants to merge 1 commit into
Conversation
…ing idle models in llm-cold-storage.sh
Collaborator
|
Thanks for this contribution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
In
ods/scripts/llm-cold-storage.sh,do_archive()moves idle Hugging Face models from$HF_CACHEto$COLD_DIR/$nameusingmv. In fresh installations or on systems where cold storage maintenance has not yet executed, the$COLD_DIRdirectory does not exist on disk, causingmvto fail withNo such file or directoryand aborting maintenance tasks underset -euo pipefail.Call
mkdir -p "$COLD_DIR"prior to model relocation, ensuring the target storage directory is established before moving model weights. Existing directory validation, idle time thresholds, and symlink creation contracts remain untouched.Validation
llm-cold-storage.sh --executewith an absent$COLD_DIRfailed withAssertionError: Cold storage directory was not created.test_cold_storage_initial_directory.pyexecutesllm-cold-storage.sh --execute, confirms$COLD_DIRis created on demand, and verifies that archived models are relocated and valid symlinks are maintained in$HF_CACHE.Overlap check
Searched live open/closed PRs touching
llm-cold-storage.sh. #5386 anchors relative symlink targets; this PR strengthens initial target directory creation during idle model archival. Their scopes do not overlap or conflict.Risk / AI disclosure
AI-assisted investigation, implementation and CLI regressions. This strengthens initial archive directory creation boundaries. Independent human review and platform/runtime qualification remain gates. No running configuration, deployment or upstream merge changed.
Follow-up integration evidence
Composed with #5386 at 3c186f3 without conflicts. Production and test diffs passed together; cold storage symlink contracts remain intact.
Backlog composition was local-only (production/test diffs, excluding workflow/Makefile wiring); it is not an upstream merge or independent human approval. Declared live-review gates remain open.