Repository navigation
fix(pixel): show omitted lines across alternating diff rows - #5077
Merged
gabsprogrammer merged 1 commit intoSep 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A truncated Pixel file diff can display nonconsecutive replacements without an omission marker. Added rows have no old line number and removed rows have no new line number, so comparing only adjacent rows loses both positions across alternating replacements.
Track the last observed old and new positions independently. Mark each omitted span before the affected side's next retained row, without synthesizing context or changing verified counts.
Why this matters
Reviewers must see where source text was omitted instead of reading separated edits as contiguous. The shipped snapshot producer skips an individual row that exceeds its remaining response budget, then retains smaller later rows, so this is reachable with a long unchanged line between two replacements.
Overlap check
Searched open/closed titles and PixelFileChanges.jsx changes for diff gaps, omitted lines and context. #4027 is a broader UI/workspace proposal; #4147 (merged) adds filters/folding and #4320 (merged) binds clipboard receipts. None preserves line coordinates across opposite-side rows.
Validation
AI assistance and review
AI-assisted implementation and validation. Independent review remains pending. This is a frontend presentation change; the publisher was exercised on isolated real filesystem snapshots, not a running user stack.
Review status and composition
Candidate ab93c45: 4 skipped, 32 success. Independent review remains outstanding.
All 20 companion changes compose at local synthetic head aef9e2e41b8acfe6e7f3e548d0affae03c88fb7f: 1,112 frontend tests, 72 focused API tests and the related CLI suites pass; frontend build/lint pass (0 errors, 597 existing warnings), and all 24 workflow YAML files parse. This unpublished test head also includes #4986/#4987, #3039 and the #3189/#3288 tests; it is not an installed-stack qualification.