Repository navigation
fix(remote-provider): preserve edits made during configuration - #4570
Merged
gabsprogrammer merged 1 commit intoSep 13, 2026
Merged
gabsprogrammer merged 1 commit into
gabsprogrammer merged 1 commit into
Conversation
This was referenced Sep 12, 2026
0xacee
marked this pull request as ready for review
September 13, 2026 04:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters: Editing the Remote GPU connection while a previous Configure request is pending loses the newer URL and API key when that request completes. The completion unconditionally marks the form clean, clears its key, and rehydrates it from server status.
Track the revision actually submitted. Clear a submitted draft only if it has not been edited since. Hydrate clean forms in the status response update itself, so displaying the form does not leave a later passive effect queued to overwrite input.
Validation:
Overlap check: searched all-state titles and changed files for RemoteProvider/draft preservation. #3039 adds peer-download polling; #3275/#3208 add helper/summary tests; #4207 introduced the compact views. None handles submitted form revision ownership.
AI assistance: implemented and tested with Codex. Review required before merge: independent review of provider lifecycle UI. Browser requests were synthetic; no live provider was configured.
Combined validation: c08b6695ff14 on public-beta base 9fc9f61. Dashboard: 906 passed; lint exits 0; production build passes. The initial default-worker run timed out in Settings; Settings alone passed all 11 tests, followed by all 906 with four workers.
Backlog compatibility: candidate includes #3039 and passes the 15-test RemoteProvider suite within 63 affected UI tests. Retain peer-download polling without restoring the removed passive form-hydration effect; hydrate clean forms in loadStatus.