Repository navigation
Conversation
This was referenced Sep 12, 2026
Collaborator
|
Thanks for this contribution. |
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this matters
After transcription or inference fails for a recorded voice message, Retry last message currently sends the placeholder text Voice message to the text endpoint. Retain the original File in the in-memory user message and dispatch retries through the audio endpoint so transcription receives the same recording. Text and attachment retries keep their current routes.
Overlap check
Searched open and closed upstream PRs by semantic title and the changed production files using a complete GitHub PR file inventory (through #4443, 2026-09-12). Searched voice/audio/retry titles and all ODSTalk.jsx changes. #2959 is recorder teardown, #3177 is playback/image cleanup, and the existing image retry behavior is covered in the baseline suite. None retains or routes the failed audio recording on retry.
Validation
git diff --checkand pre-commit checks on all changed files: passed.8cfa20f0f30d3432464d3546c92fa29e1239f115. Base:9fc9f610(public-beta).Scope and rollback
This browser change applies to the same dashboard bundle on Linux, macOS and Windows. Tests exercise the production component/hook with controlled browser events and I/O; no live-device or hardware behavior is claimed. No host/service configuration or persisted format changes. Revert this commit to restore the previous behavior.
Batch integration receipt (2026-09-12)
9fc9f610.npm test -- --maxWorkers=4939 tests passed in 118 files;npm run lint0 errors, 577 warnings;npm run buildpassed.python -m pytest tests/test_talk.py tests/test_talk_attachment_encoding.py -q45 passed.2a35c1e5:make lint, all four platform dispatch/smoke scripts, and installer simulation passed. Later changes add tests and adjust two progress labels only.make gateis not green locally: the installer noninteractive-sudo test has two failures reproduced unchanged on base9fc9f610. BATS has 416/421 passing, with five WSL/root-environment failures also reproduced on that base. These are recorded limits, not passing gates. Full-repository private-key scanning also flags pre-existing test fixtures; changed-file pre-commit checks pass.Merge coordination
Suggested sequence: #4444, #4445, #4446, #4447, #4448, #4449, #4450, #4451, #4453, #4454, #4455, #4456, #4457, #4458, #4459, #4460, #4461, #4462, #4463, #4464. Each PR is independently based on public-beta; the sequence is for applying and verifying the combined batch, not a claim of stacked base branches.
Three textual reconciliations are preserved in the integration head: #4459 retains #4447 reader cleanup/terminal framing plus stop-abort guards; #4461 combines the GFM and copy-component imports; #4463 retains both the caption-limit notice and jump-to-latest action. Other merges applied automatically. Rerun the focused suites and combined dashboard checks after upstream integration; revert the relevant PR commit to roll back its behavior. No upstream PR has been merged by this batch.
Current PR candidate:
8cfa20f0f30d3432464d3546c92fa29e1239f115.Follow-up
8cfa20f0qualifies the FileReader test global for ESLint; focused validation passed.