-
Notifications
You must be signed in to change notification settings - Fork 10
chore(release): bump version set to 10.0.10 #1984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
561563e
6bde742
69ad5e1
92f6f61
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,10 @@ | ||
| { | ||
| "name": "@origintrail-official/dkg", | ||
| "version": "10.0.9", | ||
| "version": "10.0.10", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🔴 Bug: 10.0.10 can still install on Node runtimes that cannot run it What's wrong Example Suggested direction For Agents There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🟡 Issue: Declare the Node runtime invariant at the package that owns sqlite What's wrong Example Suggested direction Confidence note For Agents
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Fixed in part, deferred in part — tracked in #1985. Done in this PR: Correction to the suggested range: Deferred to 10.0.11 (#1985), by maintainer decision: enforcement. 10.0.10 therefore ships the declaration plus an explicit |
||
| "type": "module", | ||
| "engines": { | ||
| "node": ">=22.13.0 <23.0.0 || >=23.4.0" | ||
| }, | ||
| "main": "dist/cli.js", | ||
| "bin": { | ||
| "dkg": "./dist/cli.js" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Bug: Standalone agent package lacks the new Node runtime contract
What's wrong
The release declares the new
node:sqliteruntime requirement only on the CLI package. The public@origintrail-official/dkg-agentpackage is also being released as 10.0.10 and contains the agent startup paths that open RFC-64 inventory and finalization recovery stores throughnode:sqlite. Direct agent consumers can install this release on unsupported Node versions with no package-manager warning and only discover the incompatibility as a startup failure.Example
On Node 22.12,
npm install @origintrail-official/dkg-agent@10.0.10would not warn about an unsupported runtime. A direct consumer that creates an agent withdataDirand callsstart()then reachesprepareRfc64PersistenceV1()and fails withrequires Node runtime support for node:sqlitebefore networking starts. The expected behavior is that the unsupported runtime is declared on the package that exposes and starts that code.Suggested direction
Propagate the
engines.noderequirement to the public package that owns the SQLite-backed agent runtime, not only to the CLI wrapper.Confidence note
This assumes
@origintrail-official/dkg-agentis still intended to be a standalone public package, which is consistent with its public package name, publish config, root exports, and allowlisted RFC-64 subpath exports.For Agents
Add the same supported Node range to
packages/agent/package.jsonand any other public package that directly exposes startup/runtime APIs requiringnode:sqlite. Preserve the CLI engine range, and add/update a release metadata check proving all publishable runtime packages that can open RFC-64/finalization SQLite declare the contract.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed in part, deferred in part — tracked in #1985.
Done in this PR:
engines.nodeis now declared as>=22.13.0 <23.0.0 || >=23.4.0on both@origintrail-official/dkg(packages/cli) and@origintrail-official/dkg-agent(packages/agent). The agent package is the one that owns thenode:sqlitecode, and it is the complete set —packages/agentis the only package referencingnode:sqlitein src;node-uiuses the nativebetter-sqlite3dep and is unaffected.Correction to the suggested range:
>=22.5.0would not have fixed this.node:sqliteships from 22.5.0 but stays behind--experimental-sqliteuntil 22.13.0 (and 23.4.0 on the 23.x line), and the daemon builds its command fromprocess.execArgvand never passes that flag. A bare>=22.13.0would also wrongly admit 23.0–23.3. Your 🟡 on CHANGELOG.md:15 had the right number; the two findings are resolved together at 22.13.Deferred to 10.0.11 (#1985), by maintainer decision: enforcement.
enginesis advisory — verified both ways: pnpmWARN Unsupported engine+ exit 0, npmEBADENGINE+ exit 0; both hard-fail only underengine-strict. The larger gap is that blue-green auto-update gates activation onexistsSyncof build output (auto-update.ts:1407-1418/:578-598) and never proves the slot boots, so an unsupported runtime can activate and then restart-loop. #1985 covers a capability probe (process.getBuiltinModule('node:sqlite'), which also handles--without-sqlitebuilds and correctly passes 22.10 + flag), wiring atdkg start, the daemon, bothswapSlotsites, anode-runtimedoctor check inUPDATE_PREFLIGHT_CHECKS, and your 🟡 asking for a release-metadata guard against drift.10.0.10 therefore ships the declaration plus an explicit
### Known issuesentry stating thatenginesdoes not block and that auto-update can activate an unbootable slot.