Fix errors when Orienteer was reload#2
Open
vitalii-honchar wants to merge 4 commits into
Open
Conversation
PhantomYdn
requested changes
Mar 23, 2017
| classCache = new HashMap<>(); | ||
| for (OClass oClass : db.getMetadata().getSchema().getClasses()) { | ||
| if (OTelegramModule.TELEGRAM_SEARCH.getValue(oClass)) { | ||
| if (OTelegramCustomAttributes.TELEGRAM_SEARCH.getOrCreate().getValue(oClass)) { |
Member
There was a problem hiding this comment.
When we discussed that I thought that you will use CustomAttributes and add "getOrCreate()" method there instead of creating separate class OTelegramCustomAttributes. Any problems with dynamic loading in that case? If no - lets get rid of OTelegramCustomAttributes.
| propertiesList.add(OTelegramCustomAttributes.TELEGRAM_DOCUMENTS_LIST.getOrCreate().getName()); | ||
| propertiesList.add(OTelegramCustomAttributes.TELEGRAM_CLASS_DESCRIPTION.getOrCreate().getName()); | ||
| propertiesList.add(OTelegramCustomAttributes.TELEGRAM_SEARCH_QUERY.getOrCreate().getName()); | ||
| structureTable = new OrienteerStructureTable<OClass, String>("attributes", model, propertiesList) { |
Member
There was a problem hiding this comment.
Theoretically you can use CustomAttribute instead of String here.
| /** | ||
| * @author Vitaliy Gonchar | ||
| */ | ||
| public enum OTelegramCustomAttributes { |
Member
There was a problem hiding this comment.
Commented below. It seems to be quite dummy file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.