Speeding Up Hypotheses Merging in Multi-Trace Inference#119
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We used to do a O(n) look-up to find hypotheses that specifies the same invariants (these hypotheses are generated from different traces). The found hypotheses will be merged by merging the list corresponding
positive_examplesandnegative_examples.This design causes significant slow down when multi-trace inference is performed at a very large-scale (e.g. on 5+ traces from
transformersexamples) and cause the inference to halt.This PR makes the look-up and merging process constant. Prior to this PR, with around 5K hypotheses, find and merge one hypothesis will take ~1.3s. After this PR, merging all 5K hypotheses finishes instantly.