fix(campaign): use typed Error::Overflow in calculate_refund_amount#71
Open
Bug-Hunter-X wants to merge 1 commit into
Open
Conversation
Replace debug_assert! and .expect() with panic_with_error so refund math failures surface stable Error::Overflow on-chain in release builds. Closes OrbitChainLabs#33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR fixes
calculate_refund_amountin the campaign contract so refund arithmetic failures use the contract's typedError::Overflowpanic path instead ofdebug_assert!and.expect(). This ensures zero-denominator and overflow checks remain active in release/WASM builds and that off-chain clients can match failures against stable error discriminants.Related Issue
Closes #33
Changes
🛡️ Typed Error Handling in Refund Math
campaign/src/lib.rsdebug_assert!(refund_denominator > 0)with a runtimepanic_with_error(env, Error::Overflow)check..expect("overflow in refund numerator")withchecked_mul(...).unwrap_or_else(|| panic_with_error(env, Error::Overflow)).&Envthroughcalculate_refund_amountand itsclaim_refundcall site.🧪 Tests
[MODIFY]
campaign/src/test/claim_refund_tests.rsAdded unit tests asserting
Error(Contract, #17)on zero denominator, negative denominator, and integer overflow.Added integration tests through
claim_refundfor overflow and zero-denominator paths.Added anti-dust floor regression test.
[ADD]
campaign/test_snapshots/test/claim_refund_tests/*.jsonAdded Soroban test snapshots for the new negative-path and anti-dust tests.
Verification Results
debug_assert!removed; replaced with typedpanic_with_error.expect()replaced withunwrap_or_else+panic_with_errorcalculate_refund_amountaccepts&Env