fix: replace non-standard ms_skip event with documented milestone_rel…#62
Open
Tobi-8 wants to merge 1 commit into
Open
fix: replace non-standard ms_skip event with documented milestone_rel…#62Tobi-8 wants to merge 1 commit into
Tobi-8 wants to merge 1 commit into
Conversation
…ease_skipped topic - Add missing timestamp variable in multi_asset_release.rs - Replace raw symbol_short event publish with event::milestone_release_skipped using documented (campaign, milestone_release_skipped) topic - Add milestone_release_completed summary event after per-asset loop - Add event assertions to native asset skip test - Document both events in docs/events.md
Contributor
|
Hi @Tobi-8 👋 — the intent to swap the non-standard |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes non-standard internal event topic
("ms_skip", "no_issuer")in multi-asset milestone release. The rawsymbol_short!event was undocumented and used an ad-hoc namespace that couldn't be distinguished from other module events.Changes
symbol_short!event publish withevent::milestone_release_skipped()using documented("campaign", "milestone_release_skipped")topic (consistent with other lifecycle events)event::milestone_release_skipped— the real bug was a missingtimestampvariable declaration that would cause a compilation error for themilestone_release_completedsummary event added after the looplet timestamp = env.ledger().timestamp();to the multi_asset_release functionmilestone_release_completedsummary event fires after the per-asset loop with(milestone_index, total_released, asset_count, timestamp)so indexers can detect end-of-release without counting per-asset eventstest_native_asset_skip_emits_eventwith event assertions for bothmilestone_release_skippedandmilestone_release_completeddocs/events.mdAcceptance Criteria
("campaign", "milestone_release_skipped")docs/events.mdlists the new event with topics, payload fields, and reason enummilestone_release_completedsummary event fires after the per-asset loopcloses #49