fix: separate common and campaign error discriminants#61
Open
Danservfinn wants to merge 1 commit into
Open
Conversation
Contributor
|
Hi @Danservfinn 👋 — thanks for putting this up. Issue #41 isn't currently assigned to anyone in this repo, so I can't merge under our contributor-matches-assignee policy on this pass. Could you ask a maintainer to assign #41 to you? Once that's done I'll re-confirm CI is still green and merge ✅ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
common::ErrorCodediscriminants into a reserved1000..=1099workspace range1..=999and common shared ranges in code comments and deployment notesCloses #41
Validation
cargo test -p orbitchain-campaign error_discriminant_tests -- --nocapturecargo test -p orbitchain-commongit diff --checkcommon/src/lib.rscodes1000..1003;campaign/src/types.rscodes1..80