Implement real campaign suspension notifications with email and in-app delivery#35
Open
Just-Bamford wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Statement
AdminService.suspendCampaignhad a critical notification failure that left campaign creators completely unaware of suspensions:this pr Closes #6
sendCampaignSuspensionEmailmethod only logged to console with a TODO comment - no actual email was sentcreator-${creatorId}@platform.internalthat cannot receive mailResult: Admins could confidently suspend a campaign, see the API return success, but the creator receives nothing - leaving them confused and unable to respond.
Solution Implemented
1. Professional Email Template
Added
campaignSuspensionTemplatetoemail-templates.ts:2. Real Email Delivery via Bull Queue
Replaced the TODO stub in
notifications.service.tswith full implementation:prisma.user.findUniqueQUEUE_EMAIL) for async processing3. In-App Notification Creation
Creates a persistent notification in the database:
CAMPAIGN_UPDATED(using existing enum)relatedIdfield4. Graceful Error Handling
Updated
AdminService.suspendCampaign:notificationSent: booleanflag to indicate delivery status5. API Transparency
Updated
AdminController.suspendCampaign:{ message: string, notificationSent: boolean }notificationSentflagNotification Flow
Admin suspends campaign
↓
Update campaign.status = CANCELLED
↓
Write audit log
↓
[TRY]
Fetch creator from database (prisma.user.findUnique)
↓
Validate email exists
↓
Render HTML template with suspension data
↓
Queue email job via Bull (QUEUE_EMAIL)
↓
Create in-app notification (prisma.notification.create)
↓
Log success
↓
Return { message: "...", notificationSent: true }
[CATCH]
Log error (creator not found, no email, queue failure)
↓
Return { message: "...", notificationSent: false }