test: add MilestonesService unit tests#27
Merged
Conversation
Contributor
|
@Adeolu01 please fix the failing CI. |
Contributor
|
Nice coverage on MilestonesService — closes the gap cleanly. Thanks for putting this together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #20
The repository had a single spec file (
src/app.controller.spec.ts) and no service-level coverage, making the donation/campaign/refund flows costly to change safely.This PR adds unit tests for
MilestonesService— one of the highest-risk modules called out in the issue — withPrismaServicefully mocked (no DB or Horizon/Soroban RPC). Coverage includes fund-release authorization, milestone-status guards, amount validation, duplicate-pending rejection, cancellation rules, and status aggregation.It establishes the mocked-Prisma pattern that follow-up PRs can extend to the remaining services (
DonationsService,CampaignsService,StellarTransactionsService,SorobanService), the requested e2e endpoints, and the CI coverage-threshold wiring (#18).