Nvl 1618 move libraries to trusted publishing#1
Conversation
PR Compliance Guide 🔍Below is a summary of compliance checks for this PR:
Compliance status legend🟢 - Fully Compliant🟡 - Partial Compliant 🔴 - Not Compliant ⚪ - Requires Further Human Verification 🏷️ - Compliance label |
|||||||||||||||||||||||||
PR Code Suggestions ✨Explore these optional code suggestions:
|
|||||||||||
There was a problem hiding this comment.
Pull request overview
This PR migrates the package publishing process from Bun to Node.js to support npm's Trusted Publishing via OIDC authentication. This eliminates the need for manually managed authentication tokens by leveraging GitHub Actions' OIDC integration with npm.
Key Changes:
- Adds npm package-lock.json for dependency management with Node.js
- Introduces GitHub Actions workflow for automated publishing with Trusted Publishing
- Configures Node.js version v24.12.0 via .nvmrc
Reviewed changes
Copilot reviewed 2 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| package-lock.json | Adds npm lock file with project dependencies (@types/node, typescript, yaml, change-case) for Node.js-based builds |
| .nvmrc | Specifies Node.js v24.12.0 for consistent runtime environment |
| .gitignore | Removes package-lock.json from ignore list to track it in version control (required for npm ci) |
| .github/workflows/publish.yml | Implements automated publishing workflow with OIDC/Trusted Publishing, including tag validation and provenance |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
AG-Labs
left a comment
There was a problem hiding this comment.
Everything looks good but im not seeing what I would expect in npmjs.com?
AG-Labs
left a comment
There was a problem hiding this comment.
has dry run turned on
remove that and do another beta deploy under 1.1.1 once the actions are all updated. if that works we can merge and then ill move onto looking at the other prs
PR Type
Enhancement
Description
Add GitHub Actions workflow for automated package publishing with OIDC Trusted Publishing support
Replace bun with Node.js for OIDC compatibility in publishing pipeline
Add validation step to ensure git tag matches package.json version
Lock Node.js version to v24.12.0 via .nvmrc file
Diagram Walkthrough
File Walkthrough
publish.yml
GitHub Actions workflow for OIDC package publishing.github/workflows/publish.yml
provenance
.nvmrc
Lock Node.js version to v24.12.0.nvmrc