Repository navigation
Docs: add the missing mailer keys and login.default_email_domain to the Configuration page - #160
Robertpaschal wants to merge 1 commit into
Conversation
Preview approval requiredThis pull request comes from a fork, so Mintlify won't build a preview until someone with write access approves commit |
|
@Robertpaschal is attempting to deploy a commit to the idan lodzki's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
Thanks for your contribution! Join our Slack: https://join.slack.com/t/opsimate/shared_invite/zt-39bq3x6et-NrVCZzH7xuBGIXmOjJM7gA Please make sure to include an image with your PR — it really helps us review and understand the changes better. Only in rare cases will we accept a PR without one. Also, take a moment to review your code to ensure it’s clear, readable, and easy to follow. PRs from contributors who haven’t joined our Slack community or starred the repository won’t be reviewed — we’d love to see you join and be part of the project! |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Document login and SMTP settings opsimate-docs/docs/getting-started/configuration.md |
The guide adds the login domain key and environment variable, and documents optional SMTP settings, their YAML-only availability, and first-admin welcome-email behavior. |
Assessment against linked issues
| Objective | Addressed | Explanation |
|---|---|---|
Document replyTo, TLS certificate verification, welcome-template settings and behavior, and login default email domain configuration [#1314] |
✅ |
Possibly related PRs
- OpsiMate/documentation#156: Changes the same configuration page to document the same login-domain and mailer settings.
Suggested reviewers: sridharkalaibala
Priority:
Change: Other · Severity of issue fixed: Low
Merge Risk: 
Minimal · up to 349a5
-
No actionable issue was verified in this documentation-only change.
Finishing Touches: 💡 1
-
🛠️ Fix failing CI checks: 💡
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
The Configuration page says it covers every key the server reads, but some mailer keys were missing:
replyTo,tls.rejectUnauthorized, and the welcome email'ssubjectandcontent. So waslogin.default_email_domainand itsLOGIN_DEFAULT_EMAIL_DOMAINvariable.This adds them to the example
mailerblock (commented out) with a short table of defaults and effects. It also says plainly thatrejectUnauthorized: falseturns off certificate checks and is only for self-signed SMTP servers, notes that only the first admin gets the welcome email, and says these mailer keys have no env var. The login key goes in the key reference table and the variable in the "always apply" table, with a note that the file value wins.I checked each key against
apps/server/src/config/config.ts,mail-client.ts,utils/mailTemplate.tsanduser.bl.tson main, andnpm run buildpasses with no broken links. Screenshot attached.Closes OpsiMate/OpsiMate#1314
Summary by CodeRabbit