Repository navigation
fix(cd): remote_deploy.sh never deployed the worker - #340
Merged
Merged
Conversation
The pull / teardown / up / health-verify service lists all read 'redis logger core api web' — the Go Worker was in none of them, so every CD run since the worker joined the stack reported full success while silently leaving the previously-running worker container (or a locally built one) in place. That is how the worker drifted to a pre-#339 build while the other four services were at the merge tip. The worker is added to all four lists. It has an image: mapping in docker-compose.ghcr.yml and publishes on every Publish run, so CD now pulls, restarts, and health-verifies it exactly like the other services.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deployment gap
Post-merge verification of #339 found the Go Worker running a pre-#339 build (91da93c) while the other four services were at the merge tip (bbb4bbf).
Root cause:
scripts/remote_deploy.sh— the CD runner — had the service listredis logger core api webin all four steps (pull, teardown, up, health-verify). The worker was in none of them, so every CD run since the worker joined the stack reported full success while silently leaving whatever worker container was already running (or a locally-built one) in place. The health-verify step could not even detect it: the worker was outside its service list.Fix
The worker is added to all four lists. It already has an
image:mapping indocker-compose.ghcr.ymland publishes on every Publish run, so CD now pulls, restarts, and health-verifies it exactly like the other services.Note
This is what caused the stale worker in the #339 post-merge verification; without it, #339's worker-side fixes (reconciler, extension staging, media-rejection fallback) would have stayed undeployed indefinitely while CI and the deploy pipeline read green.