This repository was archived by the owner on Jan 24, 2022. It is now read-only.
Use posix.relative() instead of path.relative()#1559
Open
yurenju wants to merge 1 commit intoOpenZeppelin:masterfrom
Open
Use posix.relative() instead of path.relative()#1559yurenju wants to merge 1 commit intoOpenZeppelin:masterfrom
yurenju wants to merge 1 commit intoOpenZeppelin:masterfrom
Conversation
in solc-js, file path is used as key to manage dependencies, the contract body is retrieved via file path, so if: `import "./Contract2.sol";` appears, solc-js will use "./Contract2.sol" to lookup the body of contract which need to be place into it. but when we use path.relative() to handle file path, it will transform from "./Contract2.sol" to ".\Contract2.sol" then solc-js cannot find correct contract body, finally throw "File import callback not supported" so path.posix.relative() should be used in this case to ensure file path follows POSIX rule for a key to index contract body.
|
bump? |
Contributor
|
Hi @FrozenKiwi, We’ve decided it’s best to focus our upgradeability efforts on the Upgrades Plugins exclusively, and have halted development on the OpenZeppelin CLI. I recommend using OpenZeppelin Upgrades Plugins: https://docs.openzeppelin.com/upgrades-plugins/1.x/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed #1558
in solc-js, file path is used as key to manage dependencies, the contract body is retrieved via file path, so if:
import "./Contract2.sol";appears, solc-js will use "./Contract2.sol" to lookup the body of contract which need to be place into it.but when we use path.relative() to handle file path, it will transform from "./Contract2.sol" to ".\Contract2.sol" then solc-js cannot find correct contract body, finally throw "File import callback not supported".
so path.posix.relative() should be used in this case to ensure file path follows POSIX rule for a key to index contract body.