Conversation
tirumerla
approved these changes
Apr 28, 2026
Comment on lines
+133
to
+136
| const resolvedPrimaryType = primaryType ?? Object.keys(structTypes)[0]; | ||
| if (!resolvedPrimaryType) { | ||
| throw new Error('signTypedData: typedData has no user-defined struct type'); | ||
| } |
Contributor
There was a problem hiding this comment.
Should we add any additional validation to check structTypes length before to guard against upstream changes blindly signing the wrong struct
| const readCount = async (): Promise<Hex> => { | ||
| const encrypted = await signer.readContract({ | ||
| address: contractAddress, | ||
| abi: counterAbi as never, |
Contributor
There was a problem hiding this comment.
nit: Can we do strict casting here and drop never?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR will introduce implementation of Zama SDK Generic Signer and an example on how to use new Zama SDK with OpenZeppelin Relayer.
Testing Process
Checklist
npx changeset add)