Repository navigation
Refactor pretraining loaders for self-contained LeRobot v3 datasets - #55
Merged
Merged
Conversation
KraHsu
approved these changes
Oct 25, 2026
KraHsu
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed all 49 changed files against 782e313, including the four dataset adapters, shared LeRobot v3 reader, statistics lookup and validation, action/state representations and masks, mixture indexing, Hydra configuration, and retained benchmark consumers. No actionable regressions found.
Local validation: 489 tests passed; Ruff, syntax parsing of 414 Python files, and git diff --check passed. The broader test attempt also had 11 failures and one collection error caused by missing torchvision/modelscope dependencies; additional model-dependent tests could not be completed. GitHub CI and Docker checks are green. Full-scale dataset decoding and GPU training were not independently reproduced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pretraining now loads the self-contained, cleaned LeRobot v3 versions of AgiBotWorld-Beta, RoboCOIN, DROID, and InternData-A1. Readers consume the supplied statistics inside each dataset family without frame-filter CSVs, external statistics roots, or loader-side statistics generation. Retired pretraining readers and utilities are removed; benchmark statistics tools retain their shared accumulator.
Move the standalone YAMLs and
mixture.yamlintoconfigs/dataloader/. Selectingdataloader=mixtureenables all four sources with full-data, proportional sampling. The training default remains RoboTwin. README updates document the pretraining command and announce the dataset releases and 1K-star milestone, including each dataset's Hugging Face link.Review fixes also make video offsets honor each camera's canonical LeRobot timestamps, bound family statistics lookup, reject malformed or mismatched statistics, and support arbitrary leading batch dimensions in the Euler conversion helpers. Video readers retain the cumulative-offset fallback for older benchmark metadata. Mixture indexing now uses bounded temporary storage and an in-place shuffle while preserving the previous seeded ordering and sample counts.
Validation
git diff --checkpass. Compilation passes.Existing baseline failure
tests/test_cosmos_predict25_registry.py::test_cosmos_predict25_build_with_bad_path_raises_clear_errorfails withRuntimeError: No CUDA GPUs are availableon this server: the installed Cosmos/Transformer Engine stack initializes CUDA before validating the deliberately nonexistent checkpoint path. The identical failure is reproduced in a detached, unmodifiedmainworktree at782e3133f674449e2986754cfc5f7c4e204835a2using the same environment. The model and test files involved are unchanged by this PR. GPU/model training and exhaustive decoding of every dataset frame were not run.