Conversation
wvpm
commented
Feb 16, 2026
wvpm
commented
Feb 16, 2026
wvpm
commented
Feb 16, 2026
wvpm
force-pushed
the
track_pop_id_in_province
branch
from
5f50223 to
2262720
Compare
Spartan322
reviewed
Feb 16, 2026
wvpm
force-pushed
the
track_pop_id_in_province
branch
from
b5120cb to
9deec08
Compare
Spartan322
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A pop must be identifiable so we can recruit a specific pop via game actions.
As province ticks are part of work bundles see ThreadPool.cpp. Work bundles are meant to be processsed in parallel.
The pop id generation must support this parallel processing. This is why the id is unique per province.
To target a specific pop, you must send the pop_id_in_province and the province_index.