Repository navigation
chore(core): @openvtc/vti-didcomm-js 0.16; vm-key.ts delegates to the library - #430
Merged
Merged
Conversation
… library 0.16 ships vti-didcomm-js #38 (did:webs resolution), #39 (the verification-method module this package carried a port of) and #37 (didwebvh-ts 3). vm-key.ts keeps its TypeScript surface and calls @openvtc/vti-didcomm-js/verification-method, so there is one implementation of the key-selection rules (R4.1). Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
@openvtc/pnm-corefrom@openvtc/vti-didcomm-js^0.14.0 to ^0.16.0. This is the follow-up #429 planned.What 0.16 brings
keyAgreementkey even when a P-256 key is listed first (Multi-listener inbound — one warm session per onboarded VTA (PR 3 of N) #39).didwebvh-ts3 (Multi-VTA holder storage + per-VTA wrap reuse (PR 1 of N) #37).did/vm-key.tskeeps its TypeScript surface (publicKeyOf,selectKey,x25519KeyAgreement, the curve constants and types). It now delegates to@openvtc/vti-didcomm-js/verification-methodinstead of carrying a rule-for-rule port, so the key-selection rules have one implementation (R4.1). About 200 lines removed.Behaviour change:
didwebvh-ts3 refuses a did:webvh whose host isn't a fully qualified domain. A dev build (allowPrivate) can no longer verifydid:webvh:<scid>:localhost%3A8000, so a local webvh server needs an FQDN host name. A did:scid whose log names an FQDN still resolves fromsrc=localhost:<port>. The lockfile resolvesdidwebvh-ts3.1.0.Checks:
npm run lint,npm run buildandnpm testpass locally (core 1329, extension 1559, plus the other workspaces); no test changes were needed. Constraint floors in CLAUDE.md (^0.6.2 / ^0.10.0 / ^0.11.0 / ^0.12.0) are all satisfied.