Repository navigation
docs(demo-rp): restore the README's paths and note the VTA's private-endpoint opt-in - #428
Merged
Merged
Conversation
…endpoint opt-in The scope move (#45) replaced every '/' in this README with '@openvtc/pnm-', so its URLs, routes and paths no longer read as such. Restored them, kept the package name in the title, and noted that a VTA admits a loopback loginUrl only with VTA_ALLOW_PRIVATE_ENDPOINTS=1. Signed-off-by: Glenn Gore <glenn.g@affinidi.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two documentation fixes to
packages/demo-rp/README.md.Restored paths. The scope move in #45 replaced every
/in this README with@openvtc/pnm-, so it readhttp:@openvtc/pnm-@openvtc/pnm-127.0.0.1:4040@openvtc/pnm-api@openvtc/pnm-logininstead ofhttp://127.0.0.1:4040/api/login, and the same for every route, task URI and path. This puts them back. Compared against the README as first written (#15): the only remaining differences are the later CORS changes and the note below. The title is the package name,@openvtc/pnm-demo-rp.VTA opt-in for the loopback login URL. VTI's vault proxy-login now admits a loopback or private
loginUrlonly when the VTA runs withVTA_ALLOW_PRIVATE_ENDPOINTS=1(OpenVTC/verifiable-trust-infrastructure#2680); without it,vault/upsertrefuses this demo's entry andvault/proxy-loginrefuses to post to it. The README now says so in the wallet-setup section and besideHOST. Until #2680 is released, the variable is harmless.No code changes.
Pre-merge checklist