feature/CPC-12213-update-pod-to-spm#28
Conversation
brianinatinyhome
changed the title
|
Hello @brianinatinyhome check out this PR from the source forked repo i made for RTCMTLVideoView, it use RTC_SUPPORTS_METAL to support also non Metal devices. https://github.com/cordova-rtc/cordova-plugin-iosrtc/pull/427/changes |
| let sdpSemanticsConfig = pcConfig?.object(forKey: "sdpSemantics") as? String; | ||
| let sdpSemantics = (sdpSemanticsConfig != nil && allowedSdpSemantics[sdpSemanticsConfig!] != nil) ? | ||
| allowedSdpSemantics[sdpSemanticsConfig!] : RTCSdpSemantics.planB | ||
| allowedSdpSemantics[sdpSemanticsConfig!] : RTCSdpSemantics.unifiedPlan |
There was a problem hiding this comment.
Good catch was already fixed in iosrtc.
https://github.com/cordova-rtc/cordova-plugin-iosrtc/blob/fd7e3931d698b1c181619b8ca94d88b3b016d514/src/PluginRTCPeerConnectionConfig.swift#L44
| class iRTCPeerConnectionConfig { | ||
|
|
||
| fileprivate let allowedSdpSemantics = [ | ||
| "plan-b": RTCSdpSemantics.planB, |
There was a problem hiding this comment.
I would still allow it to support old webrtc api usage. We kept it in iosrtc.
brianinatinyhome
changed the title
|
@hthetiot Hey Harold, thanks for the comments. Just to clarify, this branch is not intended to merge into master. We're in the process of migrating to SPM as a package manager for our projects and needed to accomodate for that with a minimal amount of changes. The plan is just to point to this specific branch through SPM |
2 participants
Item Tracking
Jira link: https://combinedpublic.atlassian.net/browse/CPC-12213
Description
This PR changes the WKWebViewRTC Library to be compatible with SPM
Test Plan
Further Comments
None.