Codechange: replace SINGLETON macros with template classes#64
Merged
PeterN merged 1 commit intoOpenTTD:masterfrom Mar 11, 2026
Merged
Codechange: replace SINGLETON macros with template classes#64PeterN merged 1 commit intoOpenTTD:masterfrom
PeterN merged 1 commit intoOpenTTD:masterfrom
Conversation
PeterN
force-pushed
the
de-macro-singletons
branch
from
d557c8a to
c918709
Compare
rubidium42
reviewed
Mar 11, 2026
Contributor
rubidium42
left a comment
rubidium42
left a comment
There was a problem hiding this comment.
Using default constructors and destructors might be better. Not quite sure whether it'll compile though.
PeterN
force-pushed
the
de-macro-singletons
branch
from
c918709 to
6b02adb
Compare
rubidium42
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Singleton (and static) classes are implemented via macros.
Use template classes instead, to improve code clarity.