Codechange: replace auto_array with std::vector#63
Merged
PeterN merged 1 commit intoOpenTTD:masterfrom Mar 10, 2026
Merged
Conversation
7bfff26 to
c6cffdb
Compare
Contributor
|
Have you noticed that MSVC is complaining quite a bit about |
c6cffdb to
3ca0d8a
Compare
Member
Author
Not any more. |
rubidium42
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
auto_arrayis a strange contraption to handle dynamically-sized arrays.new[]externally, and then passed in via an implicit constructor.delete[]in its destructor.Replace all uses with
std::vectorinstead.The code using this looks pretty fragile, so access to the vector elements is via the
at()method, instead of array indexer.Touched code has been auto-formatted for readibility...