Add ORBPath, ORBPathCallbacks, and ORBPathStorage APIs #12
+762
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ORBPathMakeWithCGPath, ORBPathMakeRect, ORBPathMakeEllipse, ORBPathMakeRoundedRect, ORBPathMakeUnevenRoundedRect with Swift init names - Add ORB_SWIFT_NAME to ORBPathStorageInit
- Move callback typedefs and ORBPathCallbacks struct to ORBPath.h - Move ORBPathEmptyCallbacks and ORBPathCGPathCallbacks declarations to ORBPath.h - Remove ORBPathPrivate.h - Update ORBPath.cpp to include ORBPath.h directly - Fix Storage constructor to use atomic_fetch_add_explicit for identifier - Add cgpath() method with lazy CGPath caching at offset 0x38
- Add ORBRoundedCornerStyle enum with Circular and Continuous options - Add style parameter to ORBPathMakeRoundedRect before transform - Add style parameter to ORBPathMakeUnevenRoundedRect before transform - TODO: Implement continuous curvature for non-circular style
…ture - Delete ORBPathElement struct, use enum directly - Add ORBPathElementFixedRoundedRectCircular and ORBPathElementFixedRoundedRectContinuous - Update ORBPathApplyCallback to pass element and points as separate parameters
- ORBPathContainsPoint: tests if a single point is inside the path - ORBPathContainsPoints: tests multiple points with optional transform - eoFill parameter controls even-odd vs non-zero winding rule - TODO: implement point containment testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements the path system for OpenRenderBox, matching RenderBox ABI.
New APIs
Path Creation (Darwin)
ORBPathMakeWithCGPathORBPathMakeRectORBPathMakeEllipseORBPathMakeRoundedRectORBPathMakeUnevenRoundedRectGlobal Constants
ORBPathEmpty- Empty pathORBPathNull- Null path sentinelTests
Audited for 6.5.1