feat: restore PHP 8.3 support (3.2.0)

.github/workflows/qa.yml

@@ -45,6 +45,34 @@ jobs:
         if: matrix.dependencies == 'lowest'
         run: composer qa:lowest
 
+  # PHP 8.3 is a supported runtime; static analysis and tooling gates run on 8.4+ where PHPUnit 13 is available.
+  php83-runtime:
+    name: PHP 8.3 / lowest dependencies runtime
+    runs-on: ubuntu-latest
+
+    steps:
+      - name: Check out the repository
+        uses: actions/checkout@v7
+
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '8.3'
+          extensions: bcmath, mbstring, zlib
+          coverage: none
+          tools: composer:v2
+
+      - name: Install lowest supported dependencies for PHP 8.3
+        run: |
+          composer config platform.php 8.3.0
+          composer require --dev --no-update "phpunit/phpunit:^12.5"
+          composer update --no-interaction --prefer-dist --prefer-lowest
+
+      - name: Run syntax and unit tests
+        run: |
+          composer test:syntax
+          composer test:unit
+
   quality-gates:
     name: Coverage and mutation gates
     runs-on: ubuntu-latest

CHANGELOG.md

@@ -1,5 +1,11 @@
 # Changelog
 
+## 3.2.0 (2026-11-09)
+
+- Restored PHP 8.3 support. The minimum had been raised to 8.4.1 with the v3 tooling update, but the library only used three PHP 8.4 constructs (`new` without parentheses in two places and `array_all()`); these are replaced with PHP 8.3 equivalents without behaviour changes.
+- CI adds a PHP 8.3 lowest-dependency job that runs syntax checks and the full test suite with PHPUnit 12.5. Development tooling, static analysis and coverage/mutation gates stay on PHP 8.4+ with PHPUnit 13.
+- No runtime API or SAV/ZSAV format changes.
+
 ## 3.1.2 (2026-11-09)
 
 - Fixed the very long string record (type 7, subtype 14): every `NAME=WIDTH` entry, including the last one, now ends with NUL + tab as SPSS and PSPP write it. IBM SPSS Statistics previously ignored the record and showed each 252-byte segment of a string wider than 255 bytes as a separate variable (`NAME_A`, `NAME_B`, ...).

README.md

@@ -11,7 +11,7 @@ Maintained by [OpenStatSpec](https://github.com/OpenStatSpec). This project cont
 
 ## Requirements
 
-- PHP 8.4.1 or newer
+- PHP 8.3 or newer
 - mbstring extension
 - bcmath extension
 - zlib extension

composer.json

@@ -33,7 +33,7 @@
     "source": "https://github.com/OpenStatSpec/php-spss"
   },
   "require": {
-    "php": "^8.4.1",
+    "php": "^8.3",
     "ext-bcmath": "*",
     "ext-mbstring": "*",
     "ext-zlib": "*"

docs/index.md

@@ -4,7 +4,7 @@ PHP-SPSS v3 provides a typed, row-oriented model for reading, inspecting, creati
 
 ## Requirements and file support
 
-- PHP 8.4.1 or newer
+- PHP 8.3 or newer
 - `mbstring`, `bcmath`, and `zlib` extensions
 - unencrypted SAV (`$FL2`) and ZSAV (`$FL3`) files
 

src/Sav/DatasetAssembler.php

@@ -564,7 +564,13 @@ private function allNumeric(array $variableNames, VariableDictionary $dictionary
         if ([] === $variableNames) {
             return false;
         }
-        return array_all($variableNames, fn(string $variableName): bool => VariableType::NUMERIC === $dictionary->variable($variableName)?->type);
+        foreach ($variableNames as $variableName) {
+            if (VariableType::NUMERIC !== $dictionary->variable($variableName)?->type) {
+                return false;
+            }
+        }
+
+        return true;
     }
 
     /** @return array<string, string> */

src/Sav/Reader.php

@@ -171,7 +171,7 @@ public function toDataset(bool $includeData = true): Dataset
             throw new \LogicException('Reader data must be loaded before including rows in a dataset.');
         }
 
-        return new DatasetAssembler()->assemble($this, $includeData);
+        return (new DatasetAssembler())->assemble($this, $includeData);
     }
 
     public function readHeader(): static

src/Sav/Record.php

@@ -22,7 +22,7 @@ public function __construct(array $data = [])
                 throw new \InvalidArgumentException(sprintf('Unknown %s property "%s".', static::class, $key));
             }
 
-            new \ReflectionProperty($this, $property)->setValue($this, $value);
+            (new \ReflectionProperty($this, $property))->setValue($this, $value);
         }
     }
 

tests/HeaderValidationTest.php

@@ -51,11 +51,11 @@ public function testZlibCompressionRequiresFl3(): void
     public function testValidCompressionHeaderPairsCanBeWritten(): void
     {
         $savBuffer = Buffer::factory();
-        new Header(['recType' => Header::NORMAL_REC_TYPE, 'compression' => 1])->write($savBuffer);
+        (new Header(['recType' => Header::NORMAL_REC_TYPE, 'compression' => 1]))->write($savBuffer);
         $this->assertSame(176, $savBuffer->position());
 
         $zsavBuffer = Buffer::factory();
-        new Header(['recType' => Header::ZLIB_REC_TYPE, 'compression' => 2])->write($zsavBuffer);
+        (new Header(['recType' => Header::ZLIB_REC_TYPE, 'compression' => 2]))->write($zsavBuffer);
         $this->assertSame(176, $zsavBuffer->position());
     }
 }

tests/InfoAttributeRecordsTest.php

@@ -81,7 +81,7 @@ public function testAttributeRecordCountUsesEncodedBytes(): void
 
         $buffer->rewind();
         self::assertSame(7, $buffer->readInt());
-        $parsed = new InfoCollection()->fill($buffer)[DataFileAttributes::SUBTYPE];
+        $parsed = (new InfoCollection())->fill($buffer)[DataFileAttributes::SUBTYPE];
         self::assertSame($expected, $parsed->toArray());
     }
 
@@ -112,8 +112,8 @@ public function testInfoCollectionPreservesAndMergesDuplicateVariableAttributeRe
         ];
 
         $buffer = Buffer::factory('', ['memory' => true]);
-        new VariableAttributes(['data' => $firstData])->write($buffer);
-        new VariableAttributes(['data' => $secondData])->write($buffer);
+        (new VariableAttributes(['data' => $firstData]))->write($buffer);
+        (new VariableAttributes(['data' => $secondData]))->write($buffer);
         $buffer->rewind();
 
         $collection = new InfoCollection();
@@ -149,7 +149,7 @@ public function testMalformedAttributeRecordsHaveClearErrors(
 
         $this->expectException(1 === $size ? \UnexpectedValueException::class : Exception::class);
         $this->expectExceptionMessage($message);
-        new InfoCollection()->fill($buffer);
+        (new InfoCollection())->fill($buffer);
     }
 
     /** @return iterable<string, array{int, int, string, string}> */
@@ -194,7 +194,7 @@ private function roundTrip(DataFileAttributes|VariableAttributes $record): DataF
         $record->write($buffer);
         $buffer->rewind();
         self::assertSame(7, $buffer->readInt());
-        $parsed = new InfoCollection()->fill($buffer)[$record::SUBTYPE];
+        $parsed = (new InfoCollection())->fill($buffer)[$record::SUBTYPE];
         if (!$parsed instanceof DataFileAttributes && !$parsed instanceof VariableAttributes) {
             throw new \LogicException(sprintf('Unexpected record type %s.', $parsed::class));
         }

tests/InfoSetRecordsTest.php

@@ -163,7 +163,7 @@ public function testMalformedRecordsHaveClearErrors(int $subtype, int $size, str
         $this->expectException(1 === $size ? \UnexpectedValueException::class : Exception::class);
         $this->expectExceptionMessage($message);
 
-        new InfoCollection()->fill($buffer);
+        (new InfoCollection())->fill($buffer);
     }
 
     /** @return iterable<string, array{int, int, string, string}> */
@@ -205,7 +205,7 @@ public function testVariableSetsWriterRejectsAmbiguousIdentifiers(array $data, s
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage($message);
-        new VariableSets(['data' => $data])->write(Buffer::factory('', ['memory' => true]));
+        (new VariableSets(['data' => $data]))->write(Buffer::factory('', ['memory' => true]));
     }
 
     /** @return iterable<string, array{int, array<string, array<string, mixed>>, string}> */
@@ -253,7 +253,7 @@ public function testMultipleResponseSetsWriterRejectsInvalidSemantics(
     ): void {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage($message);
-        new MultipleResponseSets(['subtype' => $subtype, 'data' => $data])
+        (new MultipleResponseSets(['subtype' => $subtype, 'data' => $data]))
             ->write(Buffer::factory('', ['memory' => true]));
     }
 
@@ -264,7 +264,7 @@ private function roundTrip(VariableSets|MultipleResponseSets $record): VariableS
         $buffer->rewind();
         self::assertSame(7, $buffer->readInt());
 
-        $parsed = new InfoCollection()->fill($buffer);
+        $parsed = (new InfoCollection())->fill($buffer);
 
         $subtype = $record instanceof MultipleResponseSets ? $record->subtype : VariableSets::SUBTYPE;
         $parsedRecord = $parsed[$subtype];
@@ -284,7 +284,7 @@ private function readRecord(int $subtype, string $payload): VariableSets|Multipl
         $buffer->write($payload);
         $buffer->rewind();
 
-        $record = new InfoCollection()->fill($buffer)[$subtype];
+        $record = (new InfoCollection())->fill($buffer)[$subtype];
         if (!$record instanceof VariableSets && !$record instanceof MultipleResponseSets) {
             throw new \LogicException(sprintf('Unexpected record type %s.', $record::class));
         }

tests/LongStringValueLabelsValidationTest.php

@@ -32,7 +32,7 @@ public function testLabelsRoundTripPreservesOrderDuplicatesAndFileEncoding(): vo
         $record->write($buffer);
         $buffer->rewind();
         self::assertSame(7, $buffer->readInt());
-        $parsed = new InfoCollection()->fill($buffer)[LongStringValueLabels::SUBTYPE];
+        $parsed = (new InfoCollection())->fill($buffer)[LongStringValueLabels::SUBTYPE];
 
         self::assertSame(
             [
@@ -66,7 +66,7 @@ public function testSingleByteFileEncodingUsesTargetByteLengthsAtEveryBoundary()
         $record->write($buffer);
         $buffer->rewind();
         self::assertSame(7, $buffer->readInt());
-        $parsed = new InfoCollection()->fill($buffer)[LongStringValueLabels::SUBTYPE];
+        $parsed = (new InfoCollection())->fill($buffer)[LongStringValueLabels::SUBTYPE];
 
         self::assertSame(
             [
@@ -83,7 +83,7 @@ public function testSingleByteFileEncodingUsesTargetByteLengthsAtEveryBoundary()
     public function testEmptyLabelRecordEmitsNoInfoRecord(): void
     {
         $buffer = Buffer::factory('', ['memory' => true]);
-        new LongStringValueLabels()->write($buffer);
+        (new LongStringValueLabels())->write($buffer);
 
         self::assertSame(0, $buffer->position());
         self::assertSame('', $buffer->read());
@@ -159,6 +159,6 @@ public function testWriterRejectsMalformedData(array $data, string $message): vo
     {
         $this->expectException(\InvalidArgumentException::class);
         $this->expectExceptionMessage($message);
-        new LongStringValueLabels(['data' => $data])->write(Buffer::factory('', ['memory' => true]));
+        (new LongStringValueLabels(['data' => $data]))->write(Buffer::factory('', ['memory' => true]));
     }
 }

tests/MalformedContainerTest.php

@@ -102,7 +102,7 @@ private function savBytes(int $compression): string
     private function container(string $body): string
     {
         $buffer = Buffer::factory('', ['memory' => true]);
-        new Header()->write($buffer);
+        (new Header())->write($buffer);
         $buffer->write($body);
         $buffer->rewind();
 

tests/RecordCountValidationTest.php

@@ -143,7 +143,7 @@ public function testInvalidInfoSizeCountsAreRejected(int $size, int $count, stri
 
         $this->expectException(Exception::class);
         $this->expectExceptionMessage($message);
-        new InfoCollection()->fill($buffer);
+        (new InfoCollection())->fill($buffer);
     }
 
     /** @return iterable<string, array{int, int, string}> */
@@ -165,6 +165,6 @@ public function testTruncatedInfoCountIsRejected(): void
 
         $this->expectException(Exception::class);
         $this->expectExceptionMessage('truncated size or count');
-        new InfoCollection()->fill($buffer);
+        (new InfoCollection())->fill($buffer);
     }
 }

tools/run-branch-coverage.php

@@ -71,7 +71,7 @@ public function run(): int
                 $this->runShard($shard, $tests);
             }
 
-            $merged = new Merger()->merge($this->shardArtifacts, false);
+            $merged = (new Merger())->merge($this->shardArtifacts, false);
             $report = ReportFacade::fromSerializedData($merged);
             $report->renderCobertura($this->reportPath);
             $summary = $report->summary();
@@ -222,4 +222,4 @@ private function removeArtifacts(array $paths): void
     }
 }
 
-exit(new BranchCoverageRunner()->run());
+exit((new BranchCoverageRunner())->run());