Skip to content

fix(promo-codes): persist quantity_available for generic SUMMIT_PROMO_CODE class #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smarcet merged 1 commit into from
Aug 14, 2026
+29 −0
Merged

fix(promo-codes): persist quantity_available for generic SUMMIT_PROMO_CODE class #586

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions app/Models/Foundation/Summit/Factories/SummitPromoCodeFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,6 +190,11 @@ public static function populate(SummitRegistrationPromoCode $promo_code, Summit
$promo_code->setAllowsToReassign(boolval($data['allows_to_reassign']));

switch ($data['class_name']){
case SummitRegistrationPromoCode::ClassName:{
if(isset($data['quantity_available']))
$promo_code->setQuantityAvailable(intval($data['quantity_available']));
}
break;
case SummitRegistrationDiscountCode::ClassName:
case PrePaidSummitRegistrationDiscountCode::ClassName:{
if(isset($data['amount']))
Expand Down
24 changes: 24 additions & 0 deletions tests/Unit/Services/SummitPromoCodeFactoryTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

use App\Models\Foundation\Summit\Factories\SummitPromoCodeFactory;
use models\summit\Summit;
use models\summit\SummitRegistrationPromoCode;
use models\summit\SummitRegistrationDiscountCode;
use models\summit\SummitRegistrationDiscountCodeTicketTypeRule;
use models\summit\SummitTicketType;
Expand Down Expand Up @@ -93,4 +94,27 @@ public function testPopulateAppliesAmountAndRateWhenNoTicketTypesRulesInPayload(
$this->assertEquals(25.0, $code->getRate(),
'flat rate must be applied when the payload carries no ticket_types_rules');
}

/**
* Regression: populate()'s per-class switch had no case for the generic
* SUMMIT_PROMO_CODE class, so quantity_available was silently dropped on
* create and update - codes meant to be limited (one-off, N uses) ended up
* with 0 (= unlimited) in the DB.
*/
public function testPopulatePersistsQuantityAvailableForGenericSummitPromoCode(): void
{
$summit = $this->createMock(Summit::class);

$code = new SummitRegistrationPromoCode();

$data = [
'class_name' => SummitRegistrationPromoCode::ClassName,
'quantity_available' => 24,
];

SummitPromoCodeFactory::populate($code, $summit, $data);

$this->assertEquals(24, $code->getQuantityAvailable(),
'quantity_available must be persisted for the generic SUMMIT_PROMO_CODE class');
}
}
Loading