Skip to content

Feature: Extend Swagger Coverage for controller OAuth2SummitMembersApiController - #429

Merged
smarcet merged 3 commits into
mainfrom
feature/add-openapi-documentation-to-controller-oauthsummitmemberapicontroller
Dec 22, 2025
Merged

Feature: Extend Swagger Coverage for controller OAuth2SummitMembersApiController#429
smarcet merged 3 commits into
mainfrom
feature/add-openapi-documentation-to-controller-oauthsummitmemberapicontroller

Conversation

@andrestejerina97

Copy link
Copy Markdown
Contributor

@andrestejerina97 andrestejerina97 self-assigned this Oct 31, 2025
@andrestejerina97
andrestejerina97 force-pushed the feature/add-openapi-documentation-to-controller-oauthsummitmemberapicontroller branch from f762061 to 3d9b741 Compare November 26, 2025 18:59

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All paths missing /api/v1 prefix
Example:
"/summits/{id}/members" should be "/api/v1/summits/{id}/members"

It looks like the ICS endpoint is incorrect. It should be "/api/public/v1/summits/{id}/members/all/schedule/ics/{cid}" and public. It's accessed via a token.

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/add-openapi-documentation-to-controller-oauthsummitmemberapicontroller branch from b02af93 to 9147951 Compare December 5, 2025 16:05
@matiasperrone-exo

Copy link
Copy Markdown
Contributor

Thanks @caseylocker for the comments. Now is ready to review again

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Dec 9, 2025

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@smarcet
smarcet force-pushed the main branch 4 times, most recently from c6ecdd0 to 728ae67 Compare December 17, 2025 00:43

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit 315fe5c into main Dec 22, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants