Feature: Extend Swagger Coverage for controller OAuth2SummitSponsorshipsApiController - #428
Merged
smarcet merged 4 commits intoDec 22, 2025
Conversation
andrestejerina97
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthsummitsponsorshpcontroller
branch
2 times, most recently
from
November 25, 2025 17:52
23e1647 to
1bd9064
Compare
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthsummitsponsorshpcontroller
branch
from
December 5, 2025 15:15
1bd9064 to
bfe9201
Compare
caseylocker
requested changes
Dec 10, 2025
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
Needs x: ['required-groups'] in
#[OA\Get(
path: "/api/v1/summits/{id}/add-ons/metadata",
operationId: "getAddOnsMetadata",
description: "Get add-ons metadata",
...
The route has auth.user middleware.
x: [
'required-groups' => [
IGroup::SuperAdmins,
IGroup::Administrators,
IGroup::SummitAdministrators,
]
],
…getAddOnById and getMetadata methods
matiasperrone-exo
force-pushed
the
feature/add-openapi-documentation-to-controller-oauthsummitsponsorshpcontroller
branch
from
December 11, 2025 18:46
7d68f42 to
e22f9c7
Compare
Contributor
|
Thanks @caseylocker for the comments. Now is ready to review again.
|
caseylocker
approved these changes
Dec 11, 2025
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
Right on. Good to go.
smarcet
force-pushed
the
main
branch
4 times, most recently
from
December 17, 2025 00:43
c6ecdd0 to
728ae67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkhae