Feature | Extend Swagger Coverage for controller OAuth2SummitNotificationsApiController - #418
Merged
Merged
Conversation
andrestejerina97
added
the
documentation
andrestejerina97
force-pushed
the
feature/add-summit-notification-api-swagger
branch
from
November 18, 2025 19:02
e5e2d6f to
605e42f
Compare
andrestejerina97
force-pushed
the
feature/add-summit-notification-api-swagger
branch
from
November 18, 2025 19:03
605e42f to
12cea6a
Compare
caseylocker
requested changes
Dec 4, 2025
caseylocker
left a comment
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
SummitNotificationsAuthShemas.php
Namespace should be App\Swagger\schemas
Filename typo:
SummitNotificationsAuthShemas.php should be SummitNotificationsAuthSchemas.php
SummitPushNotificationSchemas.php
Namespace App\Swagger\Summit should be App\Swagger\schemas
matiasperrone-exo
force-pushed
the
feature/add-summit-notification-api-swagger
branch
from
December 5, 2025 15:42
3253a72 to
fcf5d42
Compare
caseylocker
requested changes
Dec 10, 2025
caseylocker
left a comment
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
SummitPushNotificationSchemas.php has namespace App\Swagger\Summit; should be namespace App\Swagger\schemas;
matiasperrone-exo
force-pushed
the
feature/add-summit-notification-api-swagger
branch
from
December 10, 2025 21:43
fcf5d42 to
d7ba204
Compare
Contributor
|
Thanks @caseylocker for the comments. Now is ready to review again. |
smarcet
force-pushed
the
main
branch
4 times, most recently
from
December 17, 2025 00:43
c6ecdd0 to
728ae67
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkh9f