Skip to content

Feature | Extend Swagger Coverage for controller OAuth2SummitDocumentsApiController - #409

Merged
smarcet merged 3 commits into
mainfrom
feature/openapi-documentation--oauth2summitdocumentsapicontroller
Dec 16, 2025
Merged

Feature | Extend Swagger Coverage for controller OAuth2SummitDocumentsApiController#409
smarcet merged 3 commits into
mainfrom
feature/openapi-documentation--oauth2summitdocumentsapicontroller

Conversation

@matiasperrone-exo

Copy link
Copy Markdown
Contributor

@matiasperrone-exo matiasperrone-exo self-assigned this Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 24, 2025

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo name space issue...
Wrong Namespace in Security Schema
File: app/Swagger/Security/SummitAuthSchema.php
namespace App\Swagger\Security; // WRONG
Should be:
namespace App\Swagger\schemas; // CORRECT

Wrong x: Parameter Key Name
Write endpoints use 'authz_groups' instead of the standard 'required-groups':
x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],
This affects 7 endpoints (all write operations).

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitdocumentsapicontroller branch from 164c7d7 to 3422da7 Compare December 3, 2025 20:26
@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @smarcet please merge if you agree.

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitdocumentsapicontroller branch from 3422da7 to b2c9ece Compare December 5, 2025 15:20
@smarcet

smarcet commented Dec 8, 2025

Copy link
Copy Markdown
Collaborator

@matiasperrone please review conflicts

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summitdocumentsapicontroller branch from b2c9ece to 8968905 Compare December 8, 2025 21:14
@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

@smarcet the conflicts are now resolved

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit 119d9cb into main Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants