Feature | Extend Swagger Coverage for controller OAuth2SponsorshipTypeApiController - #408
Merged
Merged
Conversation
andrestejerina97
force-pushed
the
feature/add-sponsorship-type-api-swagger
branch
from
November 11, 2025 21:00
95cf5bd to
80c39c4
Compare
andrestejerina97
marked this pull request as ready for review
November 11, 2025 21:00
andrestejerina97
force-pushed
the
feature/add-sponsorship-type-api-swagger
branch
from
November 14, 2025 16:03
80c39c4 to
ffe092c
Compare
caseylocker
requested changes
Dec 2, 2025
Contributor
There was a problem hiding this comment.
Formatting for tags needed.
Current: tags: ["SponsorshipTypes"]
Expected: tags: ["Sponsorship Types"]
Add SummitScopes::ReadAllSummitData to the security schema scopes in SponsorshipTypeOauthSchemas.php so:
scopes: [
SummitScopes::ReadSummitData => 'Read Sponsorship Types Data',
SummitScopes::ReadAllSummitData => 'Read All Sponsorship Types Data', // ← Add this line
SummitScopes::WriteSummitData => 'Write Sponsorship Types Data',
],
Also add operationId where needed.
matiasperrone-exo
force-pushed
the
feature/add-sponsorship-type-api-swagger
branch
from
December 9, 2025 18:50
ffe092c to
9421fa4
Compare
matiasperrone-exo
changed the title
matiasperrone-exo
added
the
documentation
matiasperrone-exo
changed the title
matiasperrone-exo
force-pushed
the
feature/add-sponsorship-type-api-swagger
branch
from
December 9, 2025 20:33
9421fa4 to
53f5b6d
Compare
caseylocker
reviewed
Dec 10, 2025
caseylocker
left a comment
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
Still need to change
tags: ["SponsorshipTypes"],
to
tags: ["Sponsorship Types"],
matiasperrone-exo
force-pushed
the
feature/add-sponsorship-type-api-swagger
branch
from
December 10, 2025 21:08
f7c2526 to
e15083a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: https://app.clickup.com/t/86b6wkh5w