Skip to content

Feature Extend Swagger Coverage for controller OAuth2SummitTrackChairScoreTypesApiController - #406

Merged
smarcet merged 4 commits into
mainfrom
feature/openapi-documentation--oauth2summittrackchairscoretypesapicontroller
Dec 16, 2025
Merged

Feature Extend Swagger Coverage for controller OAuth2SummitTrackChairScoreTypesApiController#406
smarcet merged 4 commits into
mainfrom
feature/openapi-documentation--oauth2summittrackchairscoretypesapicontroller

Conversation

@matiasperrone-exo

Copy link
Copy Markdown
Contributor

@matiasperrone-exo matiasperrone-exo added the documentation Improvements or additions to documentation label Oct 14, 2025
@matiasperrone-exo matiasperrone-exo self-assigned this Oct 14, 2025
@matiasperrone-exo matiasperrone-exo added the review Need reviewing from the developer label Nov 10, 2025
@matiasperrone-exo matiasperrone-exo removed the review Need reviewing from the developer label Nov 24, 2025

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matiasperrone-exo Quick fix...
Per project conventions, the key should be 'required-groups'.

x: [
'authz_groups' => [ // Wrong key name
IGroup::SuperAdmins,
...
]
],
Should be:
x: [
'required-groups' => [ // Correct key name
IGroup::SuperAdmins,
...
]
],

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summittrackchairscoretypesapicontroller branch from 9a0aff2 to 807dea7 Compare December 3, 2025 19:55
@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

Thanks @caseylocker for the comments. Now is ready to review again

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Inconsistent x: Parameter Key
'required-groups' is correct and is used once here.
'authz_groups' is incorrect and is used 4 times here.

Change all:

x: [
            'authz_groups' => [
//...
            ]
        ],

To

  x: [
            'required-groups' => [
//...
            ]
        ],

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summittrackchairscoretypesapicontroller branch from 807dea7 to ba84f9c Compare December 5, 2025 15:00
@matiasperrone-exo

Copy link
Copy Markdown
Contributor Author

@caseylocker done! please review

@matiasperrone-exo
matiasperrone-exo force-pushed the feature/openapi-documentation--oauth2summittrackchairscoretypesapicontroller branch from 26b1624 to 2385dd6 Compare December 11, 2025 21:02

@caseylocker caseylocker left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@smarcet smarcet left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smarcet
smarcet merged commit f691119 into main Dec 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants