feat: Extend Swagger Coverage for controller OAuth2SummitTrackChairRatingTypesApiController - #405
Merged
smarcet merged 3 commits intoDec 8, 2025
Conversation
matiasperrone-exo
added
the
documentation
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summittrackchairratingtypesapicontroller
branch
from
November 26, 2025 22:38
14accaf to
0afb12d
Compare
caseylocker
requested changes
Nov 29, 2025
caseylocker
left a comment
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
@matiasperrone-exo
Wrong namespace in security schema:
// Current (line 3)
namespace App\Swagger\Security;
// Should be
namespace App\Swagger\schemas;
Wrong x: parameter key (3 occurrences):
// Current (lines 298-300, 365-367, 439-441)
x: [
"authz_groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]
],
// Should be
x: [
"required-groups" => [IGroup::SuperAdmins, IGroup::Administrators, IGroup::TrackChairs, IGroup::TrackChairsAdmins]
],
Contributor
Author
|
Thanks @caseylocker for the comments. Now is ready to review again |
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summittrackchairratingtypesapicontroller
branch
from
December 3, 2025 20:45
0afb12d to
e947d29
Compare
caseylocker
approved these changes
Dec 3, 2025
caseylocker
left a comment
caseylocker
left a comment
Contributor
There was a problem hiding this comment.
LGTM. @smarcet if you agree please merge.
…atingTypesApiController`
…schema, fix path routes and change schema to be defined as requested
matiasperrone-exo
force-pushed
the
feature/openapi-documentation--oauth2summittrackchairratingtypesapicontroller
branch
from
December 5, 2025 15:22
ab964c8 to
7a87e56
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task:
Ref: https://app.clickup.com/t/86b6wkh7t