Skip to content

Conversation

@Elblinator
Copy link
Member

@Elblinator Elblinator commented Jan 2, 2026

resolves #5655

IMPORTANT:
If a user cannot see the LoS ALL LoS icons are now hidden

@Elblinator Elblinator added this to the 4.3 milestone Jan 2, 2026
@Elblinator Elblinator self-assigned this Jan 2, 2026
@Elblinator Elblinator added enhancement General enhancement which is neither bug nor feature Schrödinger projectname labels Jan 2, 2026
@Elblinator Elblinator assigned bspekker and unassigned Elblinator Jan 2, 2026
@Elblinator Elblinator marked this pull request as ready for review January 2, 2026 13:21
Copy link
Member

@luisa-beerboom luisa-beerboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good. Just one small point that I am unsure on. If my thoughts are unjustified, consider the code approved.

Comment on lines +366 to +367
if (this.isMultiSelect) {
return;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main place it seems to be called is when clicking the motion-list state field for that motion. That seems to be the only place unless I've overlooked something.

That field ought to be unclickable during multiselect.
Is this where that is done? Because if that functionality is already implemented in another place (like the underlying list component) this upper part of the conditional would be unnecessary, since the method would never be called in multiselect mode.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That field ought to be unclickable during multiselect.

it is sadly not not clickable and this is the place where it is secured that it's not if multiselect is turned on

If that should be changed it would be done in an issue which focuses that

@bspekker bspekker merged commit 1bd65df into OpenSlides:main Jan 6, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement General enhancement which is neither bug nor feature Schrödinger projectname

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Motion-list adjustment

3 participants