Skip to content

Conversation

@Elblinator
Copy link
Member

part of #5551

@Elblinator Elblinator added this to the 4.3 milestone Dec 29, 2025
@Elblinator Elblinator mentioned this pull request Dec 29, 2025
4 tasks
@Elblinator Elblinator marked this pull request as ready for review December 29, 2025 07:26
standalone: false
})
// eslint-disable-next-line
export class MotionContentChangeRecommendationDialogComponent extends BaseChangeRecommendationDialogComponent<MotionContentChangeRecommendationDialogComponentData> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be possible to write such cases in multiple lines. This might need other linter changes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an ignore pattern in eslint. Is that also okay?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No not really.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps you could increase line length for code to 140.

But adding line breaks here would be better. There is no reason to write this in one line.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it helps you could increase line length for code to 140.

would not be enough here. I'll write it in several lines then

@bastianjoel bastianjoel assigned Elblinator and unassigned bastianjoel Jan 5, 2026
@Elblinator Elblinator assigned bastianjoel and unassigned Elblinator Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants