Repository navigation
ci(release): breaking firmware changes bump the major version - #373
Merged
Merged
Conversation
Follow Conventional Commits for the firmware track: drop bump-minor-pre-major, so a ! or BREAKING CHANGE commit bumps the major version even from 0.x. The breaking changes merged in #359 since 0.2.0 then make the next firmware release 1.0.0; release-please regenerates the open draft (#372) accordingly, FirmwareVersion.h included. The hardware track keeps its own settings. The design-decisions page is updated to match.
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows Conventional Commits for the firmware release track: removes
bump-minor-pre-major, so a!/BREAKING CHANGE:commit bumps the major version, including from 0.x.Effect: the breaking changes merged in #359 since 0.2.0 (the
AnalogInput/AngleSensorInputconfig struct,StepperConfigdefaults, the roster request at0xFF00) make the next release 1.0.0. Once this merges, release-please regenerates the open draft #372 asrelease firmware 1.0.0: the manifest, everylibrary.json, andFirmwareVersion.h(OPENSKYHAWK_FW_*→ 1.0.0). Merging #372 tagsfirmware-v1.0.0. Nothing needs undoing afterwards, unlike arelease-aspin.The hardware track (
PCB) keeps its settings unchanged.docs/architecture/design-decisions.mdnow states the major-bump rule for firmware (the hardware 0.x rule there is unchanged).Note: this makes v1.0 the next firmware release, ahead of the #290 soak and A20 (the registered Gateway USB PID).