Skip to content

add variable id name to get_closest_points_to_point func#115

Merged
cchwala merged 2 commits into
OpenSenseAction:mainfrom
bwalraven:feature_enhancement
Nov 4, 2025
Merged

add variable id name to get_closest_points_to_point func#115
cchwala merged 2 commits into
OpenSenseAction:mainfrom
bwalraven:feature_enhancement

Conversation

@bwalraven

@bwalraven bwalraven commented Oct 28, 2025

Copy link
Copy Markdown
Contributor

@codecov

codecov Bot commented Oct 28, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.88%. Comparing base (2c3c759) to head (d02ebca).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #115   +/-   ##
=======================================
  Coverage   98.88%   98.88%           
=======================================
  Files           7        7           
  Lines         808      808           
=======================================
  Hits          799      799           
  Misses          9        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@cchwala

cchwala commented Nov 3, 2025

Copy link
Copy Markdown
Member

Thanks @bwalraven. Is this ready to be merged, i.e. should I have a quick look or do you want to update still?

@bwalraven

Copy link
Copy Markdown
Contributor Author

I don't have any plans to update this any further.
I may suggest/add other features to other functions as I use them in my work but in my opinion there's no reason to not already merge this one.

@cchwala

cchwala commented Nov 4, 2025

Copy link
Copy Markdown
Member

I had a quick look and this is a really nice additional feature with minimal changes of the existing code. Thanks!

@cchwala cchwala merged commit 7b3dfad into OpenSenseAction:main Nov 4, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[enhancement] Make spatial function more versatile with variable "id" name

2 participants