fix: pre-release hardening for 0.8.4#317
Merged
Merged
Conversation
Live web paper search added external-API latency to every community with a citations block. Default to False so communities opt in explicitly; enable it for EEGLAB, whose prompt already tells the agent to ask before running it.
Narrow the broad except in the batch search/citation loops to (OpenCiteError, TimeoutError) for expected API failures; log any other exception with a full traceback (logger.exception) so a bug no longer masquerades as a routine 'no results'. Isolate per-query/per-DOI _store_papers so one DB failure cannot abort the batch or desync metadata. Add type hints to _run.
pyalex is no longer imported anywhere; opencite pulls it in transitively. Remove the redundant direct declaration and refresh the stale OpenAlex comment.
FeedbackRequest and FeedbackEntry validate the same invariants independently; if they ever drift, guard the construction so a bad shape returns a clean 422 instead of an unhandled 500. Add a whitespace-only general-comment rejection test.
postFeedback now aborts after 10s instead of hanging indefinitely, and the general-feedback Send button is disabled while the POST is in flight so a double-click cannot store two rows.
Contributor
Preview Deployment
This preview will be updated automatically when you push new commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-release hardening for 0.8.4
Addresses the findings from the PR #316 (develop -> main) review before the release merge. All items were pre-existing in develop; none were release blockers, but they are cheap, safe robustness wins.
Changes
CitationConfig.live_searchnow defaults toFalse. Live web paper search added external-API latency (~15s cap) and anonymous OpenAlex queries to every community with acitationsblock, including prod HED, with no explicit opt-in. Enabled for EEGLAB (its prompt already tells the agent to ask first); HED stays off until its prompt is updated.exceptin the batch search/citation loops to(OpenCiteError, TimeoutError); any other exception is now logged with a full traceback instead of masquerading as "no results". Per-query/per-DOI_store_papersis isolated so one DB failure cannot abort the batch or desync metadata. Typed_run.FeedbackEntry()so an invariant-validator drift returns a clean 422 instead of an unhandled 500.postFeedbackaborts after 10s instead of hanging; the general-feedback Send button is disabled while the POST is in flight (no duplicate rows on double-click).pyalexdependency (transitive via opencite); refreshed a stale comment.scripts/widget-sri.py(was failingformat --check).Tests
live_searchoff-by-default, whitespace-only general comment -> 422.uv run --all-extras pyteston affected suites: 226 passed.ruff check+ruff format --check: clean.