fix(server): recovery-only write restrictions for Kimi fallback runs#204
Open
om952 wants to merge 1 commit into
Open
fix(server): recovery-only write restrictions for Kimi fallback runs#204om952 wants to merge 1 commit into
om952 wants to merge 1 commit into
Conversation
- Add `recovery_only` column to `heartbeat_runs` with migration 0094. - Mark runs as recovery-only when a cheap/recovery fallback model (e.g. Kimi) is used. - Add `adapterConfig.fallback.allowDeliverables` override to keep deliverable writes enabled when intended. - Guard deliverable-mutating issue routes so recovery-only runs are rejected. - Add regression tests for recovery_only reads and write-guard behavior. - Register `recovery-only-write-restrictions.test.ts` in the serialized test runner.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Changed
recovery_onlycolumn toheartbeat_runswith migration0094.adapterConfig.fallback.allowDeliverablesoverride to keep deliverable writes enabled when intended.recoveryOnlyGuardmiddleware that rejects deliverable writes for recovery-only runs.server/src/__tests__/recovery-only-write-restrictions.test.tsand register them in the serialized test runner.Verification
pnpm -r typecheckpasses across all workspace packages.pnpm exec vitest run --project @paperclipai/server server/src/__tests__/recovery-only-write-restrictions.test.tspasses (5/5).node scripts/run-vitest-stable.mjs --mode serialized --shard-index 81 --shard-count 91runs the new suite through the official CI runner and passes.Closes #31