fix(server): drain live heartbeat runs on shutdown so same-agent checkout can reenter (#30)#203
Open
om952 wants to merge 1 commit into
Open
fix(server): drain live heartbeat runs on shutdown so same-agent checkout can reenter (#30)#203om952 wants to merge 1 commit into
om952 wants to merge 1 commit into
Conversation
…kout can reenter On a graceful SIGINT/SIGTERM shutdown, every still-live heartbeat-run row (queued / running / scheduled_retry) is now cancelled and the issue locks they hold (executionRunId, checkoutRunId) are cleared. - New drainStaleHeartbeatRunsOnShutdown service, wired into index.ts shutdown handler - Audit row issue.stale_lock_takeover on adoptStaleCheckoutRun success - Tests for shutdown drain and stale-lock takeover audit behavior Closes OpenScanAI#30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thinking Path
What Changed
server/src/services/heartbeat-shutdown-drain.tswithdrainStaleHeartbeatRunsOnShutdown(db)queued,running,scheduled_retry)issues.checkoutRunId,issues.executionRunId,issues.executionAgentNameKey, andissues.executionLockedAterrorCode: "server_shutdown_stale_lock_cleanup"server/src/index.tsPromise.racetimeoutadoptStaleCheckoutRuninserver/src/services/issues.tscompanyIdto the.returning(...)clauseissue.stale_lock_takeoveractivity-log rowserver/src/__tests__/heartbeat-shutdown-drain.test.tsserver/src/__tests__/issues-checkout-stale-lock-takeover.test.tsVerification
pnpm -r typecheck pnpm --filter @paperclipai/plugin-sdk ensure-build-deps && npx vitest run server/src/__tests__/heartbeat-shutdown-drain.test.ts server/src/__tests__/issues-checkout-stale-lock-takeover.test.ts node scripts/run-vitest-stable.mjs --mode general --group general-servercloses #30