added custom model and board - added reverse logic endstop#50
added custom model and board - added reverse logic endstop#50MicioMax wants to merge 3 commits intoOpenScan-org:mainfrom
Conversation
|
Thanks for the PR! Custom builds (CUSTOM enums + MicioMax config) Endstop / move_to_endstop() Side note: the homing flow (initial angle override, hardcoded degrees, |
|
Hi, some notes on yours and more enhancements: Custom builds (CUSTOM enums + MicioMax config) Endstop / active_high move_to_endstop() timeouts device discovery in network |
|
Awesome and thanks for pushing this forward! Also, the additional feature ideas here and the process you shared on Discord sound really cool. How would you like to proceed with this and the open PR? I think we could merge this fairly quickly with a few small changes (e.g. config naming and resetting For the newer feature ideas: do you prefer opening separate PRs for those, or should we turn the current PR into a draft and merge it later as a bigger package? |
|
Hi, |
|
That sounds great, and I really like the direction. I think it makes sense to wait a little and merge after the motor sleep mode and home endpoint are included. Those two features are closely related, and merging them should still be manageable. For the other ideas (PWM light control, LCD + offline scans), I’d prefer separate PRs afterwards to keep the review smaller and avoid too much divergence and merge conflicts with the So let’s proceed like this: we keep this PR open (or convert it to draft while you finish testing), add sleep mode + home endpoint, then we merge this PR and continue with PWM / LCD in follow-up PRs. If you need any help while testing or wiring this up, feel free to ping me. |
As from Discord post, I added the ability to set a "custom" device and shield, in order to allow custom models.
I also added an "active_high" endstop parameter to use endstops with reverse logic (high when pressed instead of low).