Fix/362 birthdate not future

spp_registry/models/individual.py

@@ -104,6 +104,22 @@ def _birthdate_onchange(self):
                     }
                 }
 
+    @api.constrains("birthdate")
+    def _check_birthdate_not_future(self):
+        """Server-side backstop for future dates of birth.
+
+        ``_birthdate_onchange`` only runs in the form UI, so ORM
+        ``create`` / ``write``, CSV/Excel import, and API writes
+        (XML-RPC, API v2, DCI) bypass it and a future birthdate persists.
+        ``birthdate`` is a stored, writeable field, so this constraint
+        fires on every write path and keeps the non-stored ``age``
+        compute from ever rendering a negative string.
+        """
+        today = fields.Date.today()
+        for record in self:
+            if record.birthdate and record.birthdate > today:
+                raise ValidationError(_("Date of birth cannot be in the future."))
+
     def _recompute_parent_groups(self, records):
         field = self.env["res.partner"]._fields["force_recompute_canary"]
         # Get the 'head' vocabulary code - this is a unique membership type

spp_registry/readme/HISTORY.md

@@ -1,3 +1,7 @@
+### 19.0.2.1.5
+
+- fix(registry): reject future dates of birth on every write path. `_birthdate_onchange` only guards the form UI, so ORM `create`/`write`, CSV/Excel import, and API writes (XML-RPC, API v2, DCI) could persist a future `birthdate` — which the non-stored `age` compute then rendered as a negative string. A stored-field `@api.constrains("birthdate")` (`_check_birthdate_not_future`) now enforces this server-side; the onchange is kept as the friendlier silent-reset UX in the form (#362)
+
 ### 19.0.2.2.2
 
 - fix(registry): let an ID type be used again after its ID was removed. Removing an ID through a change request keeps the row and marks it Invalid, and the old uniqueness rule counted those dead rows — so the registrant was left with an Invalid ID and no way to add a valid one of the same type. Uniqueness now applies to live IDs only, and is refused before the write so the message names the ID type rather than surfacing a database error (#1136)

spp_registry/tests/test_constraints.py

@@ -209,3 +209,50 @@ def test_duplicate_name_rejected(self):
     def test_empty_name_rejected(self):
         with self.assertRaises(ValidationError):
             self.IDType.create({"name": False})
+
+@tagged("post_install", "-at_install")
+class TestBirthdateNotFutureConstraint(RegistryCommon):
+
+    def test_future_birthdate_rejected_on_write(self):
+        """A future birthdate set via write() raises ValidationError."""
+        future = date.today() + timedelta(days=1)
+        with self.assertRaises(ValidationError):
+            self.individual_a.write({"birthdate": future})
+
+    def test_future_birthdate_rejected_on_create(self):
+        """A future birthdate passed to create() raises ValidationError."""
+        future = date.today() + timedelta(days=1)
+        with self.assertRaises(ValidationError):
+            self.Partner.create(
+                {
+                    "name": "Time Traveller",
+                    "is_registrant": True,
+                    "is_group": False,
+                    "birthdate": future,
+                }
+            )
+
+    def test_future_birthdate_rejected_on_import(self):
+        future = date.today() + timedelta(days=1)
+        result = self.Partner.load(
+            ["name", "is_registrant", "is_group", "birthdate"],
+            [["Imported Person", "1", "0", str(future)]],
+        )
+        self.assertTrue(result["messages"], "expected a constraint message from load()")
+        self.assertFalse(result["ids"], "the future-birthdate row must not be created")
+
+    def test_today_is_allowed(self):
+        """birthdate == today is the boundary that must pass."""
+        self.individual_a.write({"birthdate": date.today()})
+        self.assertEqual(self.individual_a.birthdate, date.today())
+
+    def test_past_birthdate_allowed(self):
+        """An ordinary past birthdate writes without error."""
+        self.individual_a.write({"birthdate": date(1990, 1, 1)})
+        self.assertEqual(self.individual_a.birthdate, date(1990, 1, 1))
+
+    def test_approximate_future_birthdate_rejected(self):
+        """An approximate DOB (birthdate_not_exact) still can't be future."""
+        future = date.today() + timedelta(days=1)
+        with self.assertRaises(ValidationError):
+            self.individual_a.write({"birthdate": future, "birthdate_not_exact": True})